Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mocha from v7 to v9 #100

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Update mocha from v7 to v9 #100

merged 2 commits into from
Jun 28, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 28, 2021

mocha has been updated to v9. The breaking changes made for v8 and v9 don't affect us. Most notably they include dropping support for Node.js v10.

The "unhandled rejection" handler setup in the test helper was removed, as this is now default behaviour in mocha as of v8.2.0.

`mocha` has been updated to v9. The breaking changes made for v8 and
v9 don't affect us [1][2]. Most notably they include dropping support
for Node.js v10.

The "unhandled rejection" handler setup in the test helper was removed,
as this is now default behaviour in `mocha` as of v8.2.0 [3].

[1]: https://github.com/mochajs/mocha/releases/tag/v9.0.0
[2]: https://github.com/mochajs/mocha/releases/tag/v8.0.0
[3]: mochajs/mocha#2640 (comment)
@Gudahtt Gudahtt requested a review from a team as a code owner June 28, 2021 14:41
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit b74a63c into main Jun 28, 2021
@Gudahtt Gudahtt deleted the update-mocha branch June 28, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants